iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: serio - take drv_mutex in serio_cleanup()

Browse Source 
We need to take serio->drv_mutex in serio_cleanup() to prevent the
function from being called while driver is in the middle of attaching
to a serio port. Such situation can happen with i8042 and atkbd drivers
if user rapidly presses Ctrl-Alt-Del during system startup, and leads
to kernel oops.

Reported-by: Dave Young <hidave.darkstar@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
This commit is contained in:
Dmitry Torokhov 2007-06-29 01:06:35 -04:00
parent 9f7a60d6e4
commit 33143ea1a3
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/input/serio/serio.c
View File

@ -769,8 +769,10 @@ static int serio_driver_remove(struct device *dev)
static void serio_cleanup(struct serio *serio) static void serio_cleanup(struct serio *serio)
{ {
mutex_lock(&serio->drv_mutex);
if (serio->drv && serio->drv->cleanup) if (serio->drv && serio->drv->cleanup)
serio->drv->cleanup(serio); serio->drv->cleanup(serio);
mutex_unlock(&serio->drv_mutex);
} }
static void serio_shutdown(struct device *dev) static void serio_shutdown(struct device *dev)