iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iio:light:rpr0521: Switch from CONFIG_PM guards to pm_ptr() etc

Browse Source 
Letting the compiler remove these functions when the kernel is built
without CONFIG_PM support is simpler and less error prone than the
use of #ifdef based config guards.

Removing instances of this approach from IIO also stops them being
copied into new drivers.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Mikko Koivunen <mikko.koivunen@fi.rohmeurope.com>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20220130193147.279148-50-jic23@kernel.org
This commit is contained in:
Jonathan Cameron 2022-01-30 19:31:46 +00:00
parent 05a9ddc8fc
commit 33b0a376f9
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/iio/light/rpr0521.c
View File

@ -1055,7 +1055,6 @@ static int rpr0521_remove(struct i2c_client *client)
return 0; return 0;
} }
#ifdef CONFIG_PM
static int rpr0521_runtime_suspend(struct device *dev) static int rpr0521_runtime_suspend(struct device *dev)
{ {
struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev)); struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
@ -1101,11 +1100,9 @@ static int rpr0521_runtime_resume(struct device *dev)
return 0; return 0;
} }
#endif
static const struct dev_pm_ops rpr0521_pm_ops = { static const struct dev_pm_ops rpr0521_pm_ops = {
SET_RUNTIME_PM_OPS(rpr0521_runtime_suspend, RUNTIME_PM_OPS(rpr0521_runtime_suspend, rpr0521_runtime_resume, NULL)
rpr0521_runtime_resume, NULL)
}; };
static const struct acpi_device_id rpr0521_acpi_match[] = { static const struct acpi_device_id rpr0521_acpi_match[] = {
@ -1124,7 +1121,7 @@ MODULE_DEVICE_TABLE(i2c, rpr0521_id);
static struct i2c_driver rpr0521_driver = { static struct i2c_driver rpr0521_driver = {
.driver = { .driver = {
.name = RPR0521_DRV_NAME, .name = RPR0521_DRV_NAME,
.pm = &rpr0521_pm_ops, .pm = pm_ptr(&rpr0521_pm_ops),
.acpi_match_table = ACPI_PTR(rpr0521_acpi_match), .acpi_match_table = ACPI_PTR(rpr0521_acpi_match),
}, },
.probe = rpr0521_probe, .probe = rpr0521_probe,