iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

USB: ulpi: fix bus-node lookup

Browse Source 
Fix bus-node lookup during registration, which ended up searching the whole
device tree depth-first starting at the parent (or grand parent) rather
than just matching on its children.

To make things worse, the parent (or grand-parent) node could end being
prematurely freed as well.

Fixes: ef6a7bcfb0 ("usb: ulpi: Support device discovery via DT")
Reported-by: Peter Robinson <pbrobinson@gmail.com>
Reported-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: stable <stable@vger.kernel.org>     # 4.10
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Johan Hovold
2017-11-11 16:31:18 +01:00
committed by Greg Kroah-Hartman
parent 446f666da9
commit 33c309ebc7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/common/ulpi.c
View File

@@ -180,9 +180,9 @@ static int ulpi_of_register(struct ulpi *ulpi)
/* Find a ulpi bus underneath the parent or the grandparent */ /* Find a ulpi bus underneath the parent or the grandparent */
parent = ulpi->dev.parent; parent = ulpi->dev.parent;
if (parent->of_node) if (parent->of_node)
np = of_find_node_by_name(parent->of_node, "ulpi"); np = of_get_child_by_name(parent->of_node, "ulpi");
else if (parent->parent && parent->parent->of_node) else if (parent->parent && parent->parent->of_node)
np = of_find_node_by_name(parent->parent->of_node, "ulpi"); np = of_get_child_by_name(parent->parent->of_node, "ulpi");
if (!np) if (!np)
return 0; return 0;