iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

selftests/bpf: fix "ctx:write sysctl:write read ok" on s390

Browse Source 
"ctx:write sysctl:write read ok" fails on s390 because it reads the
first byte of an int assuming it's the least-significant one, which
is not the case on big-endian arches. Since we are not testing narrow
accesses here (there is e.g. "ctx:file_pos sysctl:read read ok narrow"
for that), simply read the whole int.

Fixes: 1f5fa9ab6e2e ("selftests/bpf: Test BPF_CGROUP_SYSCTL")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
This commit is contained in:
Ilya Leoshkevich 2019-08-30 13:07:30 +02:00 committed by Daniel Borkmann
parent b963267994
commit 3404ddf234
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/testing/selftests/bpf/test_sysctl.c
View File

@ -100,7 +100,7 @@ static struct sysctl_test tests[] = {
.descr = "ctx:write sysctl:write read ok", .descr = "ctx:write sysctl:write read ok",
.insns = { .insns = {
/* If (write) */ /* If (write) */
BPF_LDX_MEM(BPF_B, BPF_REG_7, BPF_REG_1, BPF_LDX_MEM(BPF_W, BPF_REG_7, BPF_REG_1,
offsetof(struct bpf_sysctl, write)), offsetof(struct bpf_sysctl, write)),
BPF_JMP_IMM(BPF_JNE, BPF_REG_7, 1, 2), BPF_JMP_IMM(BPF_JNE, BPF_REG_7, 1, 2),