iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: v4l2-dev.c: Modified the macro SET_VALID_IOCTL

Browse Source 
Macros starting with if should be enclosed by a do - while loop
to avoid possible if/else logic defects.
So modified the macro SET_VALID_IOCTL with do - while loop.

[hverkuil: checkpatch: add parenthesis around 'ops']

Signed-off-by: lijian <lijian@yulong.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
lijian 2021-05-25 11:41:48 +02:00 committed by Mauro Carvalho Chehab
parent 80daed70c6
commit 35037eab4a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/media/v4l2-core/v4l2-dev.c
View File

@ -518,9 +518,8 @@ static int get_index(struct video_device *vdev)
return find_first_zero_bit(used, VIDEO_NUM_DEVICES); return find_first_zero_bit(used, VIDEO_NUM_DEVICES);
} }
#define SET_VALID_IOCTL(ops, cmd, op) \ #define SET_VALID_IOCTL(ops, cmd, op) \
if (ops->op) \ do { if ((ops)->op) set_bit(_IOC_NR(cmd), valid_ioctls); } while (0)
set_bit(_IOC_NR(cmd), valid_ioctls)
/* This determines which ioctls are actually implemented in the driver. /* This determines which ioctls are actually implemented in the driver.
It's a one-time thing which simplifies video_ioctl2 as it can just do It's a one-time thing which simplifies video_ioctl2 as it can just do