dt-bindings: fix the binding of Allwinner DE2 CCU of A83T and H3
The DE2 CCU is different on A83T and H3 -- the parent of the clocks on A83T is PLL_DE but on H3 it's the DE module clock. This is not noticed when I develop the DE2 CCU driver. Fix the binding by using different compatibles for A83T and H3, adding notes for the PLL_DE usage on A83T, and change the binding example's compatible from A83T to H3 (as it specifies the DE module clock). Fixes: ed74f8a8a679 ("dt-bindings: add binding for the Allwinner DE2 CCU") Signed-off-by: Icenowy Zheng <icenowy@aosc.io> Acked-by: Rob Herring <robh@kernel.org> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
This commit is contained in:
parent
e952ca3c6b
commit
3525c7c3bd
@ -4,13 +4,14 @@ Allwinner Display Engine 2.0 Clock Control Binding
|
|||||||
Required properties :
|
Required properties :
|
||||||
- compatible: must contain one of the following compatibles:
|
- compatible: must contain one of the following compatibles:
|
||||||
- "allwinner,sun8i-a83t-de2-clk"
|
- "allwinner,sun8i-a83t-de2-clk"
|
||||||
|
- "allwinner,sun8i-h3-de2-clk"
|
||||||
- "allwinner,sun8i-v3s-de2-clk"
|
- "allwinner,sun8i-v3s-de2-clk"
|
||||||
- "allwinner,sun50i-h5-de2-clk"
|
- "allwinner,sun50i-h5-de2-clk"
|
||||||
|
|
||||||
- reg: Must contain the registers base address and length
|
- reg: Must contain the registers base address and length
|
||||||
- clocks: phandle to the clocks feeding the display engine subsystem.
|
- clocks: phandle to the clocks feeding the display engine subsystem.
|
||||||
Three are needed:
|
Three are needed:
|
||||||
- "mod": the display engine module clock
|
- "mod": the display engine module clock (on A83T it's the DE PLL)
|
||||||
- "bus": the bus clock for the whole display engine subsystem
|
- "bus": the bus clock for the whole display engine subsystem
|
||||||
- clock-names: Must contain the clock names described just above
|
- clock-names: Must contain the clock names described just above
|
||||||
- resets: phandle to the reset control for the display engine subsystem.
|
- resets: phandle to the reset control for the display engine subsystem.
|
||||||
@ -19,7 +20,7 @@ Required properties :
|
|||||||
|
|
||||||
Example:
|
Example:
|
||||||
de2_clocks: clock@1000000 {
|
de2_clocks: clock@1000000 {
|
||||||
compatible = "allwinner,sun8i-a83t-de2-clk";
|
compatible = "allwinner,sun8i-h3-de2-clk";
|
||||||
reg = <0x01000000 0x100000>;
|
reg = <0x01000000 0x100000>;
|
||||||
clocks = <&ccu CLK_BUS_DE>,
|
clocks = <&ccu CLK_BUS_DE>,
|
||||||
<&ccu CLK_DE>;
|
<&ccu CLK_DE>;
|
||||||
|
Loading…
x
Reference in New Issue
Block a user