iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: exc3000 - use device core to create driver-specific device attributes

Browse Source 
Instead of creating driver-specific device attributes with
devm_device_add_group() have device core do this by setting up dev_groups
pointer in the driver structure.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20230729005133.1095051-10-dmitry.torokhov@gmail.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Dmitry Torokhov 2023-07-28 17:51:19 -07:00
parent c9110729a0
commit 354f1a2c17
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/input/touchscreen/exc3000.c
View File

@ -324,16 +324,13 @@ static ssize_t type_show(struct device *dev,
}
static DEVICE_ATTR_RO(type);
static struct attribute *sysfs_attrs[] = {
static struct attribute *exc3000_attrs[] = {
&dev_attr_fw_version.attr,
&dev_attr_model.attr,
&dev_attr_type.attr,
NULL
};
static struct attribute_group exc3000_attribute_group = {
.attrs = sysfs_attrs
};
ATTRIBUTE_GROUPS(exc3000);
static int exc3000_probe(struct i2c_client *client)
{
@ -436,10 +433,6 @@ static int exc3000_probe(struct i2c_client *client)
i2c_set_clientdata(client, data);
error = devm_device_add_group(&client->dev, &exc3000_attribute_group);
if (error)
return error;
return 0;
}
@ -464,6 +457,7 @@ MODULE_DEVICE_TABLE(of, exc3000_of_match);
static struct i2c_driver exc3000_driver = {
.driver = {
.name = "exc3000",
.dev_groups = exc3000_groups,
.of_match_table = of_match_ptr(exc3000_of_match),
},
.id_table = exc3000_id,