greybus: hid: fix null-deref on short report requests
Make sure to verify the length of incoming requests before trying to parse the request buffer, which can even be NULL on empty requests. Signed-off-by: Johan Hovold <johan@hovoldconsulting.com> Reviewed-by: Alex Elder <elder@linaro.org> Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
parent
ecf47ab9c5
commit
36257f6b4e
@ -163,6 +163,11 @@ static void gb_hid_irq_handler(u8 type, struct gb_operation *op)
|
||||
return;
|
||||
}
|
||||
|
||||
if (op->request->payload_size < 2) {
|
||||
dev_err(&connection->dev, "short report received\n");
|
||||
return;
|
||||
}
|
||||
|
||||
size = request->report[0] | request->report[1] << 8;
|
||||
if (!size) {
|
||||
dev_err(&connection->dev, "bad report size: %d\n", size);
|
||||
|
Loading…
Reference in New Issue
Block a user