iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/panel: otm8009a: Fix glitches by moving backlight enable to otm8009a_enable()

Browse Source 
The backlight 1st update was in the otm8009a_prepare() function for a
bad reason: backlight was not working in video mode and the
otm8009a_prepare() is in command mode for the init sequence. As the
backlight is now fixed (no low-power mode), it is good to put it back
in the otm8009a_enable() function, avoiding also image glitches visible
on some "slow" devices.

Signed-off-by: Philippe Cornu <philippe.cornu@st.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180423141054.13128-3-philippe.cornu@st.com
This commit is contained in:
Philippe CORNU
2018-04-23 16:10:51 +02:00
committed by Thierry Reding
parent d9f9565c1f
commit 36830ce4eb
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
View File

@ -330,13 +330,6 @@ static int otm8009a_prepare(struct drm_panel *panel)
ctx->prepared = true; ctx->prepared = true;
/*
* Power on the backlight. Note: end-user still controls brightness
* Note: ctx->prepared must be true before updating the backlight.
*/
ctx->bl_dev->props.power = FB_BLANK_UNBLANK;
backlight_update_status(ctx->bl_dev);
return 0; return 0;
} }
@ -344,6 +337,16 @@ static int otm8009a_enable(struct drm_panel *panel)
{ {
struct otm8009a *ctx = panel_to_otm8009a(panel); struct otm8009a *ctx = panel_to_otm8009a(panel);
if (ctx->enabled)
return 0;
/*
* Power on the backlight. Note: end-user still controls brightness
* Note: ctx->prepared must be true before updating the backlight.
*/
ctx->bl_dev->props.power = FB_BLANK_UNBLANK;
backlight_update_status(ctx->bl_dev);
ctx->enabled = true; ctx->enabled = true;
return 0; return 0;