iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

SSB: Fix handling of ssb_pmu_get_alp_clock()

Browse Source 
Dan Carpenter reported missing brackets which resulted in reading a
wrong crystalfreq value. I also noticed that the result of this
function is ignored.

Reported-By: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Michael Buesch <m@bues.ch>
Cc: davem@davemloft.net
Cc: netdev@vger.kernel.org
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/10536/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
This commit is contained in:
Hauke Mehrtens 2015-06-07 01:52:51 +02:00 committed by Ralf Baechle
parent d7b631419b
commit 36f6ea2b21
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/ssb/driver_chipcommon_pmu.c
View File

@ -621,8 +621,8 @@ static u32 ssb_pmu_get_alp_clock_clk0(struct ssb_chipcommon *cc)
u32 crystalfreq; u32 crystalfreq;
const struct pmu0_plltab_entry *e = NULL; const struct pmu0_plltab_entry *e = NULL;
crystalfreq = chipco_read32(cc, SSB_CHIPCO_PMU_CTL) & crystalfreq = (chipco_read32(cc, SSB_CHIPCO_PMU_CTL) &
SSB_CHIPCO_PMU_CTL_XTALFREQ >> SSB_CHIPCO_PMU_CTL_XTALFREQ_SHIFT; SSB_CHIPCO_PMU_CTL_XTALFREQ) >> SSB_CHIPCO_PMU_CTL_XTALFREQ_SHIFT;
e = pmu0_plltab_find_entry(crystalfreq); e = pmu0_plltab_find_entry(crystalfreq);
BUG_ON(!e); BUG_ON(!e);
return e->freq * 1000; return e->freq * 1000;
@ -634,7 +634,7 @@ u32 ssb_pmu_get_alp_clock(struct ssb_chipcommon *cc)
switch (bus->chip_id) { switch (bus->chip_id) {
case 0x5354: case 0x5354:
ssb_pmu_get_alp_clock_clk0(cc); return ssb_pmu_get_alp_clock_clk0(cc);
default: default:
ssb_err("ERROR: PMU alp clock unknown for device %04X\n", ssb_err("ERROR: PMU alp clock unknown for device %04X\n",
bus->chip_id); bus->chip_id);