iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tools/bootconfig: fix single & used for logical condition

Browse Source 
commit cf8c59a3756b2735c409a9b3ac1e4ec556546a7a upstream.

A single & will create a background process and return true, so the grep
command will run even if the file checked in the first condition does not
exist.

Link: https://lore.kernel.org/all/20230112114215.17103-1-antonio.feijoo@suse.com/

Fixes: 1eaad3ac3f39 ("tools/bootconfig: Use per-group/all enable option in ftrace2bconf script")
Signed-off-by: Antonio Alvarez Feijoo <antonio.feijoo@suse.com>
Cc: stable@vger.kernel.org
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Antonio Alvarez Feijoo 2023-02-22 08:27:35 +09:00 committed by Greg Kroah-Hartman
parent d41db100bc
commit 37a38ff7ed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/bootconfig/scripts/ftrace2bconf.sh
View File

@ -93,7 +93,7 @@ referred_vars() {
}
event_is_enabled() { # enable-file
test -f $1 & grep -q "1" $1
test -f $1 && grep -q "1" $1
}
per_event_options() { # event-dir