iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: Replace snprintf with scnprintf in gether_get_ifname

Browse Source 
snprintf returns the actual length of the buffer created; however,
this is not the case if snprintf truncates its parameter.
See https://lwn.net/Articles/69419/ for a detailed explanation.
The current code correctly handles this case at the expense
of extra code in the return statement.

scnprintf does returns the actual length of the buffer created
making the ?: operator unnecessary in the return
statement.

This change does not alter the functionality of the code.

Signed-off-by: Daniel M German <dmg@turingmachine.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
This commit is contained in:
Daniel M German 2019-06-19 21:50:38 -07:00 committed by Felipe Balbi
parent d29fcf7078
commit 37e444c829
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/gadget/function/u_ether.c
View File

@ -1006,9 +1006,9 @@ int gether_get_ifname(struct net_device *net, char *name, int len)
int ret;
rtnl_lock();
ret = snprintf(name, len, "%s\n", netdev_name(net));
ret = scnprintf(name, len, "%s\n", netdev_name(net));
rtnl_unlock();
return ret < len ? ret : len;
return ret;
}
EXPORT_SYMBOL_GPL(gether_get_ifname);