iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

kselftest/alsa - pcm-test: Don't include diagnostic message in test name

Browse Source 
When reporting errors or skips we currently include the diagnostic message
indicating why we're failing or skipping. This isn't ideal since KTAP
defines the entire print as the test name, so if there's an error then test
systems won't detect the test as being the same one as a passing test. Move
the diagnostic to a separate ksft_print_msg() to avoid this issue, the test
name part will always be the same for passes, fails and skips and the
diagnostic information is still displayed.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230323-alsa-pcm-test-names-v1-1-8be67a8885ff@kernel.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Mark Brown 2023-03-23 18:48:28 +00:00 committed by Takashi Iwai
parent 05a2cdfef0
commit 38bd221a9c
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/testing/selftests/alsa/pcm-test.c
View File

@ -499,17 +499,18 @@ __close:
}
if (!skip)
ksft_test_result(pass, "%s.%s.%d.%d.%d.%s%s%s\n",
ksft_test_result(pass, "%s.%s.%d.%d.%d.%s\n",
test_class_name, test_name,
data->card, data->device, data->subdevice,
snd_pcm_stream_name(data->stream),
msg[0] ? " " : "", msg);
snd_pcm_stream_name(data->stream));
else
ksft_test_result_skip("%s.%s.%d.%d.%d.%s%s%s\n",
ksft_test_result_skip("%s.%s.%d.%d.%d.%s\n",
test_class_name, test_name,
data->card, data->device, data->subdevice,
snd_pcm_stream_name(data->stream),
msg[0] ? " " : "", msg);
snd_pcm_stream_name(data->stream));
if (msg[0])
ksft_print_msg("%s\n", msg);
pthread_mutex_unlock(&results_lock);