iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

irqchip/qcom: Fix error handling

Browse Source 
'devm_ioremap()' returns NULL on error, not an error pointer.

Fixes: f20cc9b00c ("irqchip/qcom: Add IRQ combiner driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: marc.zyngier@arm.com
Cc: kernel-janitors@vger.kernel.org
Cc: jason@lakedaemon.net
Link: http://lkml.kernel.org/r/20170218083434.2289-1-christophe.jaillet@wanadoo.fr
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Christophe JAILLET 2017-02-18 09:34:34 +01:00 committed by Thomas Gleixner
parent 5d4bac9a5f
commit 3900dea4cd
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/irqchip/qcom-irq-combiner.c
View File

@ -202,9 +202,9 @@ static acpi_status get_registers_cb(struct acpi_resource *ares, void *context)
} }
vaddr = devm_ioremap(ctx->dev, reg->address, REG_SIZE); vaddr = devm_ioremap(ctx->dev, reg->address, REG_SIZE);
if (IS_ERR(vaddr)) { if (!vaddr) {
dev_err(ctx->dev, "Can't map register @%pa\n", &paddr); dev_err(ctx->dev, "Can't map register @%pa\n", &paddr);
ctx->err = PTR_ERR(vaddr); ctx->err = -ENOMEM;
return AE_ERROR; return AE_ERROR;
} }