iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

w1: ds2433: do not use assignment in if condition

Browse Source 
Assignments in if condition are less readable and error-prone.  Fixes
also checkpatch warning:

  ERROR: do not use assignment in if condition

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20230415104304.104134-7-krzysztof.kozlowski@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Krzysztof Kozlowski 2023-04-15 12:42:55 +02:00 committed by Greg Kroah-Hartman
parent 921e0f2fb0
commit 39bbfdacae
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/w1/slaves/w1_ds2433.c
View File

@ -98,7 +98,8 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj,
u8 wrbuf[3];
#endif
if ((count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE)) == 0)
count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE);
if (!count)
return 0;
mutex_lock(&sl->master->bus_mutex);
@ -208,7 +209,8 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj,
struct w1_slave *sl = kobj_to_w1_slave(kobj);
int addr, len, idx;
if ((count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE)) == 0)
count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE);
if (!count)
return 0;
#ifdef CONFIG_W1_SLAVE_DS2433_CRC