iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: ll_temac: platform_get_resource replaced by wrong function

Browse Source 
The function platform_get_resource was replaced with
devm_platform_ioremap_resource_byname and is called using 0 as name.

This eventually ends up in platform_get_resource_byname in the call
stack, where it causes a null pointer in strcmp.

	if (type == resource_type(r) && !strcmp(r->name, name))

It should have been replaced with devm_platform_ioremap_resource.

Fixes: bd69058f50d5 ("net: ll_temac: Use devm_platform_ioremap_resource_byname()")
Signed-off-by: Claus Hansen Ries <chr@terma.com>
Cc: stable@vger.kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/cca18f9c630a41c18487729770b492bb@terma.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Claus Hansen Ries 2024-03-21 13:08:59 +00:00 committed by Jakub Kicinski
parent afb373ff3f
commit 3a38a829c8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/xilinx/ll_temac_main.c
View File

@ -1443,7 +1443,7 @@ static int temac_probe(struct platform_device *pdev)
} }
/* map device registers */ /* map device registers */
lp->regs = devm_platform_ioremap_resource_byname(pdev, 0); lp->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(lp->regs)) { if (IS_ERR(lp->regs)) {
dev_err(&pdev->dev, "could not map TEMAC registers\n"); dev_err(&pdev->dev, "could not map TEMAC registers\n");
return -ENOMEM; return -ENOMEM;