iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mlxsw: spectrum_dpipe: Add missing error path

Browse Source 
In case devlink_dpipe_entry_ctx_prepare() failed, release RTNL that was
previously taken and free the memory allocated by
mlxsw_sp_erif_entry_prepare().

Fixes: 2ba5999f00 ("mlxsw: spectrum: Add Support for erif table entries access")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ido Schimmel 2020-02-07 19:26:28 +02:00 committed by David S. Miller
parent 36844c855b
commit 3a99cbb6fa
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c
View File

@ -215,7 +215,7 @@ mlxsw_sp_dpipe_table_erif_entries_dump(void *priv, bool counters_enabled,
start_again: start_again:
err = devlink_dpipe_entry_ctx_prepare(dump_ctx); err = devlink_dpipe_entry_ctx_prepare(dump_ctx);
if (err) if (err)
return err; goto err_ctx_prepare;
j = 0; j = 0;
for (; i < rif_count; i++) { for (; i < rif_count; i++) {
struct mlxsw_sp_rif *rif = mlxsw_sp_rif_by_index(mlxsw_sp, i); struct mlxsw_sp_rif *rif = mlxsw_sp_rif_by_index(mlxsw_sp, i);
@ -247,6 +247,7 @@ start_again:
return 0; return 0;
err_entry_append: err_entry_append:
err_entry_get: err_entry_get:
err_ctx_prepare:
rtnl_unlock(); rtnl_unlock();
devlink_dpipe_entry_clear(&entry); devlink_dpipe_entry_clear(&entry);
return err; return err;