iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

i2c: designware: Fix return value check in navi_amd_register_client()

Browse Source 
In case of error, the function i2c_new_client_device() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().

Fixes: 17631e8ca2 ("i2c: designware: Add driver support for AMD NAVI GPU")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
This commit is contained in:
Wei Yongjun 2021-04-07 03:11:37 +00:00 committed by Wolfram Sang
parent 010e32ab20
commit 3ab4ce2daf
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/i2c/busses/i2c-designware-pcidrv.c
View File

@ -132,8 +132,8 @@ static int navi_amd_register_client(struct dw_i2c_dev *dev)
info.irq = dev->irq;
dev->slave = i2c_new_client_device(&dev->adapter, &info);
if (!dev->slave)
return -ENODEV;
if (IS_ERR(dev->slave))
return PTR_ERR(dev->slave);
return 0;
}