iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wifi: p54: Replace zero-length array of trailing structs with flex-array

Browse Source 
Zero-length arrays are deprecated[1] and are being replaced with
flexible array members in support of the ongoing efforts to tighten the
FORTIFY_SOURCE routines on memcpy(), correctly instrument array indexing
with UBSAN_BOUNDS, and to globally enable -fstrict-flex-arrays=3.

Replace zero-length array with flexible-array member.

This results in no differences in binary output (most especially because
struct pda_antenna_gain is unused). The struct is kept for future
reference.

[1] https://github.com/KSPP/linux/issues/78

Cc: Christian Lamparter <chunkeey@googlemail.com>
Cc: Kalle Valo <kvalo@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20221118234240.gonna.369-kees@kernel.org
This commit is contained in:
Kees Cook 2022-11-18 15:42:44 -08:00 committed by Kalle Valo
parent 9e2f177de1
commit 3b79d4bad3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/wireless/intersil/p54/eeprom.h
View File

@ -108,10 +108,10 @@ struct pda_country {
} __packed; } __packed;
struct pda_antenna_gain { struct pda_antenna_gain {
struct { DECLARE_FLEX_ARRAY(struct {
u8 gain_5GHz; /* 0.25 dBi units */ u8 gain_5GHz; /* 0.25 dBi units */
u8 gain_2GHz; /* 0.25 dBi units */ u8 gain_2GHz; /* 0.25 dBi units */
} __packed antenna[0]; } __packed, antenna);
} __packed; } __packed;
struct pda_custom_wrapper { struct pda_custom_wrapper {