iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qlcnic: fix error return code in qlcnic_83xx_restart_hw()

Browse Source 
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 3ced0a88cd ("qlcnic: Add support to run firmware POST")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1605248186-16013-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Zhang Changzhong
2020-11-13 14:16:26 +08:00
committed by Jakub Kicinski
parent cfbaa8b33e
commit 3beb9be165
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
View File

@@ -2231,7 +2231,8 @@ static int qlcnic_83xx_restart_hw(struct qlcnic_adapter *adapter)
/* Boot either flash image or firmware image from host file system */ /* Boot either flash image or firmware image from host file system */
if (qlcnic_load_fw_file == 1) { if (qlcnic_load_fw_file == 1) {
if (qlcnic_83xx_load_fw_image_from_host(adapter)) err = qlcnic_83xx_load_fw_image_from_host(adapter);
if (err)
return err; return err;
} else { } else {
QLC_SHARED_REG_WR32(adapter, QLCNIC_FW_IMG_VALID, QLC_SHARED_REG_WR32(adapter, QLCNIC_FW_IMG_VALID,