iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: iio: resolver: ad2s1210: check return of ad2s1210_initial()

Browse Source 
This adds a check to the return value of ad2s1210_initial() since it
can fail. The call is also moved before devm_iio_device_register() so
that we don't have to unregister the device if it fails.

Signed-off-by: David Lechner <dlechner@baylibre.com>
Link: https://lore.kernel.org/r/20230929-ad2s1210-mainline-v3-4-fa4364281745@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
David Lechner 2023-09-29 12:23:09 -05:00 committed by Jonathan Cameron
parent 9829ebacea
commit 3c1f41d5f3
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/iio/resolver/ad2s1210.c
View File

@ -672,6 +672,10 @@ static int ad2s1210_probe(struct spi_device *spi)
if (ret < 0)
return ret;
ret = ad2s1210_initial(st);
if (ret < 0)
return ret;
indio_dev->info = &ad2s1210_info;
indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->channels = ad2s1210_channels;
@ -683,7 +687,6 @@ static int ad2s1210_probe(struct spi_device *spi)
return ret;
st->fclkin = spi->max_speed_hz;
ad2s1210_initial(st);
return 0;
}