iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sctp: remove rcu_read_lock from sctp_bind_addr_state

Browse Source 
sctp_bind_addr_state() is called either in packet rcv path or
by sctp_copy_local_addr_list(), which are under rcu_read_lock.
So there's no need to call it again in sctp_bind_addr_state().

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Xin Long 2019-07-09 00:59:40 +08:00 committed by David S. Miller
parent 6c6fbad657
commit 3cab2afb14
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
net/sctp/bind_addr.c
View File

@ -393,24 +393,19 @@ int sctp_bind_addr_state(const struct sctp_bind_addr *bp,
{
struct sctp_sockaddr_entry *laddr;
struct sctp_af *af;
int state = -1;
af = sctp_get_af_specific(addr->sa.sa_family);
if (unlikely(!af))
return state;
return -1;
rcu_read_lock();
list_for_each_entry_rcu(laddr, &bp->address_list, list) {
if (!laddr->valid)
continue;
if (af->cmp_addr(&laddr->a, addr)) {
state = laddr->state;
break;
}
if (af->cmp_addr(&laddr->a, addr))
return laddr->state;
}
rcu_read_unlock();
return state;
return -1;
}
/* Find the first address in the bind address list that is not present in