iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

btrfs: remove pointless empty log context list check when syncing log

Browse Source 
When syncing the log, if we get an error when updating the log root, we
check first if the log root tree context is in a log context list, and if
so it deletes from the log root tree context from the list. This check
however is pointless because at this moment the context is always in a
list, he have just added it to a context list. The check became pointless
after commit a93e01682e28 ("btrfs: remove no longer needed use of
log_writers for the log root tree"). So remove this now pointless empty
list check.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Filipe Manana 2023-10-05 12:11:09 +01:00 committed by David Sterba
parent 68539bd0e7
commit 3cf63ddf29
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/btrfs/tree-log.c
View File

@ -2996,9 +2996,7 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans,
*/ */
ret = update_log_root(trans, log, &new_root_item); ret = update_log_root(trans, log, &new_root_item);
if (ret) { if (ret) {
if (!list_empty(&root_log_ctx.list)) list_del_init(&root_log_ctx.list);
list_del_init(&root_log_ctx.list);
blk_finish_plug(&plug); blk_finish_plug(&plug);
btrfs_set_log_full_commit(trans); btrfs_set_log_full_commit(trans);
if (ret != -ENOSPC) if (ret != -ENOSPC)