iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: ohci-da8xx: add a helper pointer to &pdev->dev

Browse Source 
Add a helper pointer to &pdev->dev. This improves readability by
removing all the &pdev->dev dereferencing.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
This commit is contained in:
Bartosz Golaszewski 2019-02-11 11:36:56 +01:00 committed by Sekhar Nori
parent 08e46f18b7
commit 3d2ab9f35e
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/usb/host/ohci-da8xx.c
View File

@ -402,35 +402,35 @@ MODULE_DEVICE_TABLE(of, da8xx_ohci_ids);
static int ohci_da8xx_probe(struct platform_device *pdev) static int ohci_da8xx_probe(struct platform_device *pdev)
{ {
struct da8xx_ohci_hcd *da8xx_ohci; struct da8xx_ohci_hcd *da8xx_ohci;
struct device *dev = &pdev->dev;
struct usb_hcd *hcd; struct usb_hcd *hcd;
struct resource *mem; struct resource *mem;
int error, irq; int error, irq;
hcd = usb_create_hcd(&ohci_da8xx_hc_driver, &pdev->dev, hcd = usb_create_hcd(&ohci_da8xx_hc_driver, dev, dev_name(dev));
dev_name(&pdev->dev));
if (!hcd) if (!hcd)
return -ENOMEM; return -ENOMEM;
da8xx_ohci = to_da8xx_ohci(hcd); da8xx_ohci = to_da8xx_ohci(hcd);
da8xx_ohci->hcd = hcd; da8xx_ohci->hcd = hcd;
da8xx_ohci->usb11_clk = devm_clk_get(&pdev->dev, NULL); da8xx_ohci->usb11_clk = devm_clk_get(dev, NULL);
if (IS_ERR(da8xx_ohci->usb11_clk)) { if (IS_ERR(da8xx_ohci->usb11_clk)) {
error = PTR_ERR(da8xx_ohci->usb11_clk); error = PTR_ERR(da8xx_ohci->usb11_clk);
if (error != -EPROBE_DEFER) if (error != -EPROBE_DEFER)
dev_err(&pdev->dev, "Failed to get clock.\n"); dev_err(dev, "Failed to get clock.\n");
goto err; goto err;
} }
da8xx_ohci->usb11_phy = devm_phy_get(&pdev->dev, "usb-phy"); da8xx_ohci->usb11_phy = devm_phy_get(dev, "usb-phy");
if (IS_ERR(da8xx_ohci->usb11_phy)) { if (IS_ERR(da8xx_ohci->usb11_phy)) {
error = PTR_ERR(da8xx_ohci->usb11_phy); error = PTR_ERR(da8xx_ohci->usb11_phy);
if (error != -EPROBE_DEFER) if (error != -EPROBE_DEFER)
dev_err(&pdev->dev, "Failed to get phy.\n"); dev_err(dev, "Failed to get phy.\n");
goto err; goto err;
} }
da8xx_ohci->vbus_reg = devm_regulator_get_optional(&pdev->dev, "vbus"); da8xx_ohci->vbus_reg = devm_regulator_get_optional(dev, "vbus");
if (IS_ERR(da8xx_ohci->vbus_reg)) { if (IS_ERR(da8xx_ohci->vbus_reg)) {
error = PTR_ERR(da8xx_ohci->vbus_reg); error = PTR_ERR(da8xx_ohci->vbus_reg);
if (error == -ENODEV) { if (error == -ENODEV) {
@ -438,13 +438,13 @@ static int ohci_da8xx_probe(struct platform_device *pdev)
} else if (error == -EPROBE_DEFER) { } else if (error == -EPROBE_DEFER) {
goto err; goto err;
} else { } else {
dev_err(&pdev->dev, "Failed to get regulator\n"); dev_err(dev, "Failed to get regulator\n");
goto err; goto err;
} }
} }
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
hcd->regs = devm_ioremap_resource(&pdev->dev, mem); hcd->regs = devm_ioremap_resource(dev, mem);
if (IS_ERR(hcd->regs)) { if (IS_ERR(hcd->regs)) {
error = PTR_ERR(hcd->regs); error = PTR_ERR(hcd->regs);
goto err; goto err;