iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

s390/pci: move debug messages to debugfs

Browse Source 
The error messages in pci_insn are for debug purposes only. Move
them to the debugfs.

Reviewed-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Sebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
This commit is contained in:
Sebastian Ott 2015-08-18 19:39:27 +02:00 committed by Martin Schwidefsky
parent 24d05ff863
commit 3d8258e4ab
1 changed files with 23 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
arch/s390/pci/pci_insn.c
View File

@ -8,10 +8,23 @@
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/delay.h> #include <linux/delay.h>
#include <asm/pci_insn.h> #include <asm/pci_insn.h>
#include <asm/pci_debug.h>
#include <asm/processor.h> #include <asm/processor.h>
#define ZPCI_INSN_BUSY_DELAY 1 /* 1 microsecond */ #define ZPCI_INSN_BUSY_DELAY 1 /* 1 microsecond */
static inline void zpci_err_insn(u8 cc, u8 status, u64 req, u64 offset)
{
struct {
u8 cc;
u8 status;
u64 req;
u64 offset;
} data = {cc, status, req, offset};
zpci_err_hex(&data, sizeof(data));
}
/* Modify PCI Function Controls */ /* Modify PCI Function Controls */
static inline u8 __mpcifc(u64 req, struct zpci_fib *fib, u8 *status) static inline u8 __mpcifc(u64 req, struct zpci_fib *fib, u8 *status)
{ {
@ -38,8 +51,8 @@ int zpci_mod_fc(u64 req, struct zpci_fib *fib)
} while (cc == 2); } while (cc == 2);
if (cc) if (cc)
printk_once(KERN_ERR "%s: error cc: %d status: %d\n", zpci_err_insn(cc, status, req, 0);
__func__, cc, status);
return (cc) ? -EIO : 0; return (cc) ? -EIO : 0;
} }
@ -72,8 +85,8 @@ int zpci_refresh_trans(u64 fn, u64 addr, u64 range)
} while (cc == 2); } while (cc == 2);
if (cc) if (cc)
printk_once(KERN_ERR "%s: error cc: %d status: %d dma_addr: %Lx size: %Lx\n", zpci_err_insn(cc, status, addr, range);
__func__, cc, status, addr, range);
return (cc) ? -EIO : 0; return (cc) ? -EIO : 0;
} }
@ -121,8 +134,8 @@ int zpci_load(u64 *data, u64 req, u64 offset)
} while (cc == 2); } while (cc == 2);
if (cc) if (cc)
printk_once(KERN_ERR "%s: error cc: %d status: %d req: %Lx offset: %Lx\n", zpci_err_insn(cc, status, req, offset);
__func__, cc, status, req, offset);
return (cc > 0) ? -EIO : cc; return (cc > 0) ? -EIO : cc;
} }
EXPORT_SYMBOL_GPL(zpci_load); EXPORT_SYMBOL_GPL(zpci_load);
@ -159,8 +172,8 @@ int zpci_store(u64 data, u64 req, u64 offset)
} while (cc == 2); } while (cc == 2);
if (cc) if (cc)
printk_once(KERN_ERR "%s: error cc: %d status: %d req: %Lx offset: %Lx\n", zpci_err_insn(cc, status, req, offset);
__func__, cc, status, req, offset);
return (cc > 0) ? -EIO : cc; return (cc > 0) ? -EIO : cc;
} }
EXPORT_SYMBOL_GPL(zpci_store); EXPORT_SYMBOL_GPL(zpci_store);
@ -195,8 +208,8 @@ int zpci_store_block(const u64 *data, u64 req, u64 offset)
} while (cc == 2); } while (cc == 2);
if (cc) if (cc)
printk_once(KERN_ERR "%s: error cc: %d status: %d req: %Lx offset: %Lx\n", zpci_err_insn(cc, status, req, offset);
__func__, cc, status, req, offset);
return (cc > 0) ? -EIO : cc; return (cc > 0) ? -EIO : cc;
} }
EXPORT_SYMBOL_GPL(zpci_store_block); EXPORT_SYMBOL_GPL(zpci_store_block);