iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[media] rc: Deletion of unnecessary checks before two function calls

Browse Source 
The functions input_free_device() and rc_close() test whether their argument
is NULL and then return immediately. Thus the test around the call
is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Markus Elfring 2014-11-20 09:01:32 -03:00 committed by Mauro Carvalho Chehab
parent 8f1aeedf78
commit 3dd94f00f0
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/media/rc/lirc_dev.c
View File

@ -518,7 +518,6 @@ int lirc_dev_fop_close(struct inode *inode, struct file *file)
WARN_ON(mutex_lock_killable(&lirc_dev_lock)); WARN_ON(mutex_lock_killable(&lirc_dev_lock));
if (ir->d.rdev)
rc_close(ir->d.rdev); rc_close(ir->d.rdev);
ir->open--; ir->open--;

1
drivers/media/rc/rc-main.c
View File

@ -1298,7 +1298,6 @@ void rc_free_device(struct rc_dev *dev)
if (!dev) if (!dev)
return; return;
if (dev->input_dev)
input_free_device(dev->input_dev); input_free_device(dev->input_dev);
put_device(&dev->dev); put_device(&dev->dev);