iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

apparmor: fix aa_label_asxprint return check

Browse Source 
Clang static analysis reports this issue
label.c:1802:3: warning: 2nd function call argument
  is an uninitialized value
  pr_info("%s", str);
  ^~~~~~~~~~~~~~~~~~

str is set from a successful call to aa_label_asxprint(&str, ...)
On failure a negative value is returned, not a -1.  So change
the check.

Fixes: f1bd904175 ("apparmor: add the base fns() for domain labels")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: John Johansen <john.johansen@canonical.com>
This commit is contained in:
Tom Rix 2022-02-13 13:32:28 -08:00 committed by John Johansen
parent 564423bf9c
commit 3e2a3a0830
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
security/apparmor/label.c
View File

@ -1744,7 +1744,7 @@ void aa_label_xaudit(struct audit_buffer *ab, struct aa_ns *ns,
if (!use_label_hname(ns, label, flags) || if (!use_label_hname(ns, label, flags) ||
display_mode(ns, label, flags)) { display_mode(ns, label, flags)) {
len = aa_label_asxprint(&name, ns, label, flags, gfp); len = aa_label_asxprint(&name, ns, label, flags, gfp);
if (len == -1) { if (len < 0) {
AA_DEBUG("label print error"); AA_DEBUG("label print error");
return; return;
} }
@ -1772,7 +1772,7 @@ void aa_label_seq_xprint(struct seq_file *f, struct aa_ns *ns,
int len; int len;
len = aa_label_asxprint(&str, ns, label, flags, gfp); len = aa_label_asxprint(&str, ns, label, flags, gfp);
if (len == -1) { if (len < 0) {
AA_DEBUG("label print error"); AA_DEBUG("label print error");
return; return;
} }
@ -1795,7 +1795,7 @@ void aa_label_xprintk(struct aa_ns *ns, struct aa_label *label, int flags,
int len; int len;
len = aa_label_asxprint(&str, ns, label, flags, gfp); len = aa_label_asxprint(&str, ns, label, flags, gfp);
if (len == -1) { if (len < 0) {
AA_DEBUG("label print error"); AA_DEBUG("label print error");
return; return;
} }