iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: rc: check for integer overflow

Browse Source 
The ioctl LIRC_SET_REC_TIMEOUT would set a timeout of 704ns if called
with a timeout of 4294968us.

Cc: <stable@vger.kernel.org>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Sean Young 2017-10-08 14:18:52 -04:00 committed by Mauro Carvalho Chehab
parent 5ce8c7a0e6
commit 3e45067f94
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/media/rc/ir-lirc-codec.c
View File

@ -298,11 +298,14 @@ static long ir_lirc_ioctl(struct file *filep, unsigned int cmd,
if (!dev->max_timeout) if (!dev->max_timeout)
return -ENOTTY; return -ENOTTY;
/* Check for multiply overflow */
if (val > U32_MAX / 1000)
return -EINVAL;
tmp = val * 1000; tmp = val * 1000;
if (tmp < dev->min_timeout || if (tmp < dev->min_timeout || tmp > dev->max_timeout)
tmp > dev->max_timeout) return -EINVAL;
return -EINVAL;
if (dev->s_timeout) if (dev->s_timeout)
ret = dev->s_timeout(dev, tmp); ret = dev->s_timeout(dev, tmp);