iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cifs: make const array static, makes object smaller

Browse Source 
Don't populate const array smb3_create_tag_posix on the stack but
instead make it static. Makes the object code smaller by 50 bytes.

Before:
   text	   data	    bss	    dec	    hex	filename
 150184	  47167	      0	 197351	  302e7	fs/cifs/smb2pdu.o

After:
    text	   data	    bss	    dec	    hex	filename
 150070	  47231	      0	 197301	  302b5	fs/cifs/smb2pdu.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Colin Ian King 2020-10-20 15:19:36 +01:00 committed by Steve French
parent 9934430e21
commit 3ece60e3e7
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/cifs/smb2pdu.c
View File

@ -1981,9 +1981,11 @@ smb2_parse_contexts(struct TCP_Server_Info *server,
unsigned int next; unsigned int next;
unsigned int remaining; unsigned int remaining;
char *name; char *name;
const char smb3_create_tag_posix[] = {0x93, 0xAD, 0x25, 0x50, 0x9C, static const char smb3_create_tag_posix[] = {
0xB4, 0x11, 0xE7, 0xB4, 0x23, 0x83, 0x93, 0xAD, 0x25, 0x50, 0x9C,
0xDE, 0x96, 0x8B, 0xCD, 0x7C}; 0xB4, 0x11, 0xE7, 0xB4, 0x23, 0x83,
0xDE, 0x96, 0x8B, 0xCD, 0x7C
};
*oplock = 0; *oplock = 0;
data_offset = (char *)rsp + le32_to_cpu(rsp->CreateContextsOffset); data_offset = (char *)rsp + le32_to_cpu(rsp->CreateContextsOffset);