iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/amd/amdgpu : Fix NULL pointer comparison

Browse Source 
Replace direct comparisons to NULL i.e.
'x == NULL' with '!x'. As per coding standard.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Ravikant B Sharma <ravikant.s2@samsung.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Ravikant B Sharma 2016-11-08 11:19:42 +05:30 committed by Alex Deucher
parent bc24fbe9df
commit 3f12325ab8
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
View File

@ -70,7 +70,7 @@ static bool igp_read_bios_from_vram(struct amdgpu_device *adev)
return false; return false;
} }
adev->bios = kmalloc(size, GFP_KERNEL); adev->bios = kmalloc(size, GFP_KERNEL);
if (adev->bios == NULL) { if (!adev->bios) {
iounmap(bios); iounmap(bios);
return false; return false;
} }

3
drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
View File

@ -327,9 +327,8 @@ int amdgpu_sa_bo_new(struct amdgpu_sa_manager *sa_manager,
return -EINVAL; return -EINVAL;
*sa_bo = kmalloc(sizeof(struct amdgpu_sa_bo), GFP_KERNEL); *sa_bo = kmalloc(sizeof(struct amdgpu_sa_bo), GFP_KERNEL);
if ((*sa_bo) == NULL) { if (!(*sa_bo))
return -ENOMEM; return -ENOMEM;
}
(*sa_bo)->manager = sa_manager; (*sa_bo)->manager = sa_manager;
(*sa_bo)->fence = NULL; (*sa_bo)->fence = NULL;
INIT_LIST_HEAD(&(*sa_bo)->olist); INIT_LIST_HEAD(&(*sa_bo)->olist);

2
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
View File

@ -3904,7 +3904,7 @@ static int gfx_v8_0_init_save_restore_list(struct amdgpu_device *adev)
int list_size; int list_size;
unsigned int *register_list_format = unsigned int *register_list_format =
kmalloc(adev->gfx.rlc.reg_list_format_size_bytes, GFP_KERNEL); kmalloc(adev->gfx.rlc.reg_list_format_size_bytes, GFP_KERNEL);
if (register_list_format == NULL) if (!register_list_format)
return -ENOMEM; return -ENOMEM;
memcpy(register_list_format, adev->gfx.rlc.register_list_format, memcpy(register_list_format, adev->gfx.rlc.register_list_format,
adev->gfx.rlc.reg_list_format_size_bytes); adev->gfx.rlc.reg_list_format_size_bytes);