iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set

Browse Source 
If the console is unlocked during registration, the console subsystem
generates significant amounts of warnings, which obfuscate actual
debugging messages. Setting ignore_console_lock_warning while debugging
console registration avoid the noise.

v3:
	- manipulate ignore_console_lock_warning with atomic_{inc,dec}
v2:
	- restore ignore_console_lock_warning if lock_fb_info() fails

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
This commit is contained in:
Thomas Zimmermann 2018-07-31 13:06:58 +02:00 committed by Bartlomiej Zolnierkiewicz
parent 56e6c104e4
commit 3f2ce54284
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/video/fbdev/core/fbmem.c
View File

@ -1690,17 +1690,22 @@ static int do_register_framebuffer(struct fb_info *fb_info)
event.info = fb_info; event.info = fb_info;
if (!lockless_register_fb) if (!lockless_register_fb)
console_lock(); console_lock();
else
atomic_inc(&ignore_console_lock_warning);
if (!lock_fb_info(fb_info)) { if (!lock_fb_info(fb_info)) {
if (!lockless_register_fb) ret = -ENODEV;
console_unlock(); goto unlock_console;
return -ENODEV;
} }
ret = 0;
fb_notifier_call_chain(FB_EVENT_FB_REGISTERED, &event); fb_notifier_call_chain(FB_EVENT_FB_REGISTERED, &event);
unlock_fb_info(fb_info); unlock_fb_info(fb_info);
unlock_console:
if (!lockless_register_fb) if (!lockless_register_fb)
console_unlock(); console_unlock();
return 0; else
atomic_dec(&ignore_console_lock_warning);
return ret;
} }
static int unbind_console(struct fb_info *fb_info) static int unbind_console(struct fb_info *fb_info)