iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rtlwifi: prevent memory leak in rtl_usb_probe

Browse Source 
In rtl_usb_probe if allocation for usb_data fails the allocated hw
should be released. In addition the allocated rtlpriv->usb_data should
be released on error handling path.

Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Navid Emamdoost 2019-09-24 20:20:21 -05:00 committed by Kalle Valo
parent 6e7d597763
commit 3f93616951
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/wireless/realtek/rtlwifi/usb.c
View File

@ -1021,8 +1021,10 @@ int rtl_usb_probe(struct usb_interface *intf,
rtlpriv->hw = hw; rtlpriv->hw = hw;
rtlpriv->usb_data = kcalloc(RTL_USB_MAX_RX_COUNT, sizeof(u32), rtlpriv->usb_data = kcalloc(RTL_USB_MAX_RX_COUNT, sizeof(u32),
GFP_KERNEL); GFP_KERNEL);
if (!rtlpriv->usb_data) if (!rtlpriv->usb_data) {
ieee80211_free_hw(hw);
return -ENOMEM; return -ENOMEM;
}
/* this spin lock must be initialized early */ /* this spin lock must be initialized early */
spin_lock_init(&rtlpriv->locks.usb_lock); spin_lock_init(&rtlpriv->locks.usb_lock);
@ -1083,6 +1085,7 @@ error_out2:
_rtl_usb_io_handler_release(hw); _rtl_usb_io_handler_release(hw);
usb_put_dev(udev); usb_put_dev(udev);
complete(&rtlpriv->firmware_loading_complete); complete(&rtlpriv->firmware_loading_complete);
kfree(rtlpriv->usb_data);
return -ENODEV; return -ENODEV;
} }
EXPORT_SYMBOL(rtl_usb_probe); EXPORT_SYMBOL(rtl_usb_probe);