iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: vc04_services: Remove VCHIQ_QUEUE_BULK_TRANSFER_T typedef

Browse Source 
Typedefing structs is not encouraged in the kernel.

Signed-off-by: Dominic Braun <inf.braun@fau.de>
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dominic Braun 2018-12-14 13:04:58 +01:00 committed by Greg Kroah-Hartman
parent e896852528
commit 4040a7ee53
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
View File

@ -1069,7 +1069,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
case VCHIQ_IOC_QUEUE_BULK_TRANSMIT: case VCHIQ_IOC_QUEUE_BULK_TRANSMIT:
case VCHIQ_IOC_QUEUE_BULK_RECEIVE: { case VCHIQ_IOC_QUEUE_BULK_RECEIVE: {
VCHIQ_QUEUE_BULK_TRANSFER_T args; struct vchiq_queue_bulk_transfer args;
struct bulk_waiter_node *waiter = NULL; struct bulk_waiter_node *waiter = NULL;
VCHIQ_BULK_DIR_T dir = VCHIQ_BULK_DIR_T dir =
@ -1149,7 +1149,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
waiter, current->pid); waiter, current->pid);
if (copy_to_user((void __user *) if (copy_to_user((void __user *)
&(((VCHIQ_QUEUE_BULK_TRANSFER_T __user *) &(((struct vchiq_queue_bulk_transfer __user *)
arg)->mode), arg)->mode),
(const void *)&mode_waiting, (const void *)&mode_waiting,
sizeof(mode_waiting)) != 0) sizeof(mode_waiting)) != 0)
@ -1660,7 +1660,7 @@ vchiq_compat_ioctl_queue_bulk(struct file *file,
unsigned int cmd, unsigned int cmd,
unsigned long arg) unsigned long arg)
{ {
VCHIQ_QUEUE_BULK_TRANSFER_T __user *args; struct vchiq_queue_bulk_transfer __user *args;
struct vchiq_queue_bulk_transfer32 args32; struct vchiq_queue_bulk_transfer32 args32;
struct vchiq_queue_bulk_transfer32 *ptrargs32 = struct vchiq_queue_bulk_transfer32 *ptrargs32 =
(struct vchiq_queue_bulk_transfer32 *)arg; (struct vchiq_queue_bulk_transfer32 *)arg;

8
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
View File

@ -53,13 +53,13 @@ typedef struct {
const struct vchiq_element __user *elements; const struct vchiq_element __user *elements;
} VCHIQ_QUEUE_MESSAGE_T; } VCHIQ_QUEUE_MESSAGE_T;
typedef struct { struct vchiq_queue_bulk_transfer {
unsigned int handle; unsigned int handle;
void *data; void *data;
unsigned int size; unsigned int size;
void *userdata; void *userdata;
VCHIQ_BULK_MODE_T mode; VCHIQ_BULK_MODE_T mode;
} VCHIQ_QUEUE_BULK_TRANSFER_T; };
struct vchiq_completion_data { struct vchiq_completion_data {
VCHIQ_REASON_T reason; VCHIQ_REASON_T reason;
@ -107,9 +107,9 @@ struct vchiq_dump_mem {
#define VCHIQ_IOC_QUEUE_MESSAGE \ #define VCHIQ_IOC_QUEUE_MESSAGE \
_IOW(VCHIQ_IOC_MAGIC, 4, VCHIQ_QUEUE_MESSAGE_T) _IOW(VCHIQ_IOC_MAGIC, 4, VCHIQ_QUEUE_MESSAGE_T)
#define VCHIQ_IOC_QUEUE_BULK_TRANSMIT \ #define VCHIQ_IOC_QUEUE_BULK_TRANSMIT \
_IOWR(VCHIQ_IOC_MAGIC, 5, VCHIQ_QUEUE_BULK_TRANSFER_T) _IOWR(VCHIQ_IOC_MAGIC, 5, struct vchiq_queue_bulk_transfer)
#define VCHIQ_IOC_QUEUE_BULK_RECEIVE \ #define VCHIQ_IOC_QUEUE_BULK_RECEIVE \
_IOWR(VCHIQ_IOC_MAGIC, 6, VCHIQ_QUEUE_BULK_TRANSFER_T) _IOWR(VCHIQ_IOC_MAGIC, 6, struct vchiq_queue_bulk_transfer)
#define VCHIQ_IOC_AWAIT_COMPLETION \ #define VCHIQ_IOC_AWAIT_COMPLETION \
_IOWR(VCHIQ_IOC_MAGIC, 7, struct vchiq_await_completion) _IOWR(VCHIQ_IOC_MAGIC, 7, struct vchiq_await_completion)
#define VCHIQ_IOC_DEQUEUE_MESSAGE \ #define VCHIQ_IOC_DEQUEUE_MESSAGE \