iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

video: xilinxfb: constify fb_fix_screeninfo and fb_var_screeninfo structures

Browse Source 
These structures are only used to copy into other structures,
so declare them as const.

This issue was detected using Coccinelle and the following semantic patch:

@r disable optional_qualifier@
identifier i;
position p;
@@
static struct fb_fix_screeninfo i@p = { ... };

@ok@
identifier r.i;
expression e;
position p;
@@
e = i@p

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct fb_fix_screeninfo e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct fb_fix_screeninfo i = { ... };

The semantic patch for fb_var_screeninfo is analogous.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Cc: Soren Brinkmann <soren.brinkmann@xilinx.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
This commit is contained in:
Gustavo A. R. Silva 2017-08-01 17:20:39 +02:00 committed by Bartlomiej Zolnierkiewicz
parent 2d9e4e2bb5
commit 40445365a4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/video/fbdev/xilinxfb.c
View File

@ -110,14 +110,14 @@ static struct xilinxfb_platform_data xilinx_fb_default_pdata = {
/* /*
* Here are the default fb_fix_screeninfo and fb_var_screeninfo structures * Here are the default fb_fix_screeninfo and fb_var_screeninfo structures
*/ */
static struct fb_fix_screeninfo xilinx_fb_fix = { static const struct fb_fix_screeninfo xilinx_fb_fix = {
.id = "Xilinx", .id = "Xilinx",
.type = FB_TYPE_PACKED_PIXELS, .type = FB_TYPE_PACKED_PIXELS,
.visual = FB_VISUAL_TRUECOLOR, .visual = FB_VISUAL_TRUECOLOR,
.accel = FB_ACCEL_NONE .accel = FB_ACCEL_NONE
}; };
static struct fb_var_screeninfo xilinx_fb_var = { static const struct fb_var_screeninfo xilinx_fb_var = {
.bits_per_pixel = BITS_PER_PIXEL, .bits_per_pixel = BITS_PER_PIXEL,
.red = { RED_SHIFT, 8, 0 }, .red = { RED_SHIFT, 8, 0 },