iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ksmbd: ignore trailing slashes in share paths

Browse Source 
Trailing slashes in share paths (like: /home/me/Share/) caused permission
issues with shares for clients on iOS and on Android TV for me,
but otherwise they work fine with plain old Samba.

Cc: stable@vger.kernel.org
Signed-off-by: Nandor Kracser <bonifaido@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Nandor Kracser 2024-05-21 22:56:17 +09:00 committed by Steve French
parent c91ecba9e4
commit 405ee4097c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
fs/smb/server/mgmt/share_config.c
View File

@ -165,8 +165,12 @@ static struct ksmbd_share_config *share_config_request(struct unicode_map *um,
share->path = kstrndup(ksmbd_share_config_path(resp), path_len, share->path = kstrndup(ksmbd_share_config_path(resp), path_len,
GFP_KERNEL); GFP_KERNEL);
if (share->path) if (share->path) {
share->path_sz = strlen(share->path); share->path_sz = strlen(share->path);
while (share->path_sz > 1 &&
share->path[share->path_sz - 1] == '/')
share->path[--share->path_sz] = '\0';
}
share->create_mask = resp->create_mask; share->create_mask = resp->create_mask;
share->directory_mask = resp->directory_mask; share->directory_mask = resp->directory_mask;
share->force_create_mode = resp->force_create_mode; share->force_create_mode = resp->force_create_mode;