iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

power: reset: ltc2952: Remove bogus hrtimer_start() return value checks

Browse Source 
The return value of hrtimer_start() tells whether the timer was
inactive or active already when hrtimer_start() was called.

The code emits a bogus warning if the timer was active already
claiming that the timer could not be started.

Remove it along with the bogus comment in the else path.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Frans Klaver <frans.klaver@xsens.com>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-pm@vger.kernel.org
This commit is contained in:
Thomas Gleixner 2015-04-13 16:43:35 +02:00
parent b484403b9a
commit 4101ecc23d
1 changed files with 3 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/power/reset/ltc2952-poweroff.c
View File

@ -120,18 +120,7 @@ static enum hrtimer_restart ltc2952_poweroff_timer_wde(struct hrtimer *timer)
static void ltc2952_poweroff_start_wde(struct ltc2952_poweroff *data) static void ltc2952_poweroff_start_wde(struct ltc2952_poweroff *data)
{ {
if (hrtimer_start(&data->timer_wde, data->wde_interval, hrtimer_start(&data->timer_wde, data->wde_interval, HRTIMER_MODE_REL);
HRTIMER_MODE_REL)) {
/*
* The device will not toggle the watchdog reset,
* thus shut down is only safe if the PowerPath controller
* has a long enough time-off before triggering a hardware
* power-off.
*
* Only sending a warning as the system will power-off anyway
*/
dev_err(data->dev, "unable to start the timer\n");
}
} }
static enum hrtimer_restart static enum hrtimer_restart
@ -165,12 +154,10 @@ static irqreturn_t ltc2952_poweroff_handler(int irq, void *dev_id)
} }
if (gpiod_get_value(data->gpio_trigger)) { if (gpiod_get_value(data->gpio_trigger)) {
if (hrtimer_start(&data->timer_trigger, data->trigger_delay, hrtimer_start(&data->timer_trigger, data->trigger_delay,
HRTIMER_MODE_REL)) HRTIMER_MODE_REL);
dev_err(data->dev, "unable to start the wait timer\n");
} else { } else {
hrtimer_cancel(&data->timer_trigger); hrtimer_cancel(&data->timer_trigger);
/* omitting return value check, timer should have been valid */
} }
return IRQ_HANDLED; return IRQ_HANDLED;
} }