iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

target: remove the se_task task_error_status field

Browse Source 
We only reach transport_complete_task once per task, so the test and set on
task_error_status is never going to have an effect.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Christoph Hellwig 2011-11-23 06:54:15 -05:00 committed by Nicholas Bellinger
parent ef804a849f
commit 41e16e9816
2 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/target/target_core_transport.c
View File

@ -738,13 +738,7 @@ void transport_complete_task(struct se_task *task, int success)
} }
if (cmd->t_tasks_failed) { if (cmd->t_tasks_failed) {
if (!task->task_error_status) { cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
task->task_error_status =
TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
cmd->scsi_sense_reason =
TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;
}
INIT_WORK(&cmd->work, target_complete_failure_work); INIT_WORK(&cmd->work, target_complete_failure_work);
} else { } else {
atomic_set(&cmd->t_transport_complete, 1); atomic_set(&cmd->t_transport_complete, 1);

1
include/target/target_core_base.h
View File

@ -490,7 +490,6 @@ struct se_task {
u32 task_sg_nents; u32 task_sg_nents;
u16 task_flags; u16 task_flags;
u8 task_scsi_status; u8 task_scsi_status;
int task_error_status;
enum dma_data_direction task_data_direction; enum dma_data_direction task_data_direction;
atomic_t task_state_active; atomic_t task_state_active;
struct list_head t_list; struct list_head t_list;