iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gpio: twl4030: Don't return an error after WARN in .remove

Browse Source 
Returning a non-zero value in a platform driver's remove callback only
results in an error message ("remove callback returned a non-zero value.
This will be ignored.", see platform_remove()), and then the device is
removed anyhow.

As there was just a WARN_ON triggered, return 0 to drop the follow up
warning. The latter output is hardly relevant after the big WARN splat.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
This commit is contained in:
Uwe Kleine-König 2022-06-14 17:23:39 +02:00 committed by Bartosz Golaszewski
parent 2a1192ff08
commit 421e3c16c3
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/gpio/gpio-twl4030.c
View File

@ -597,12 +597,9 @@ static int gpio_twl4030_remove(struct platform_device *pdev)
gpiochip_remove(&priv->gpio_chip); gpiochip_remove(&priv->gpio_chip);
if (is_module())
return 0;
/* REVISIT no support yet for deregistering all the IRQs */ /* REVISIT no support yet for deregistering all the IRQs */
WARN_ON(1); WARN_ON(!is_module());
return -EIO; return 0;
} }
static const struct of_device_id twl_gpio_match[] = { static const struct of_device_id twl_gpio_match[] = {