iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

serial: 8250_pci: Prefer struct_size over open coded arithmetic

Browse Source 
As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the struct_size() helper to do the arithmetic instead of the
argument "size + size * count" in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Len Baker <len.baker@gmx.com>
Link: https://lore.kernel.org/r/20210905155728.11147-1-len.baker@gmx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Len Baker
2021-09-05 17:57:28 +02:00
committed by Greg Kroah-Hartman
parent 0f3b577384
commit 42c457cc9a
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/tty/serial/8250/8250_pci.c
View File

@@ -3981,9 +3981,7 @@ pciserial_init_ports(struct pci_dev *dev, const struct pciserial_board *board)
nr_ports = rc; nr_ports = rc;
} }
priv = kzalloc(sizeof(struct serial_private) + priv = kzalloc(struct_size(priv, line, nr_ports), GFP_KERNEL);
sizeof(unsigned int) * nr_ports,
GFP_KERNEL);
if (!priv) { if (!priv) {
priv = ERR_PTR(-ENOMEM); priv = ERR_PTR(-ENOMEM);
goto err_deinit; goto err_deinit;