iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: connection: Don't free resources freed by gb_connection_release()

Browse Source 
We are already doing put_device() here and so don't need to free
resources directly, except ida.

Fixes: afde17fe0b61 ("greybus/connection: fix jump label on device_add failure")
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Viresh Kumar 2015-08-13 10:40:28 +05:30 committed by Greg Kroah-Hartman
parent 22322c4745
commit 435ea76218
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/greybus/connection.c
View File

@ -270,7 +270,7 @@ gb_connection_create_range(struct greybus_host_device *hd,
pr_err("failed to add connection device for cport 0x%04hx\n",
cport_id);
goto err_free_kfifo;
goto err_remove_ida;
}
spin_lock_irq(&gb_connections_lock);
@ -296,8 +296,6 @@ gb_connection_create_range(struct greybus_host_device *hd,
return connection;
err_free_kfifo:
kfifo_free(&connection->ts_kfifo);
err_destroy_wq:
destroy_workqueue(connection->wq);
err_free_connection: