iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net/smc: dev_put for netdev after usage of ib_query_gid()

Browse Source 
For RoCEs ib_query_gid() takes a reference count on the net_device.
This reference count must be decreased by the caller.

Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Reported-by: Parav Pandit <parav@mellanox.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
Fixes: 0cfdd8f92cac ("smc: connection and link group creation")
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ursula Braun 2017-10-11 13:47:23 +02:00 committed by David S. Miller
parent d921c420d2
commit 43e2ada3e0
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
net/smc/smc_core.c
View File

@ -380,11 +380,15 @@ static int smc_link_determine_gid(struct smc_link_group *lgr)
if (ib_query_gid(lnk->smcibdev->ibdev, lnk->ibport, i, &gid, if (ib_query_gid(lnk->smcibdev->ibdev, lnk->ibport, i, &gid,
&gattr)) &gattr))
continue; continue;
if (gattr.ndev && if (gattr.ndev) {
(vlan_dev_vlan_id(gattr.ndev) == lgr->vlan_id)) { if (is_vlan_dev(gattr.ndev) &&
vlan_dev_vlan_id(gattr.ndev) == lgr->vlan_id) {
lnk->gid = gid; lnk->gid = gid;
dev_put(gattr.ndev);
return 0; return 0;
} }
dev_put(gattr.ndev);
}
} }
return -ENODEV; return -ENODEV;
} }