iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mm/slab: correct return values in comment for _kmem_cache_create()

Browse Source 
__kmem_cache_create() returns 0 on success and non-zero on failure.
The comment is wrong in two instances, so fix the first one and remove
the second one. Also make the comment non-doc, because it doesn't
describe an API function, but SLAB-specific implementation.

Signed-off-by: zhaoxinchao <chrisxinchao@outlook.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
This commit is contained in:
zhaoxinchao 2023-04-18 10:05:23 +08:00 committed by Vlastimil Babka
parent 44c026a73b
commit 444f20c29e
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mm/slab.c
View File

@ -1887,14 +1887,12 @@ static bool set_on_slab_cache(struct kmem_cache *cachep,
return true; return true;
} }
/** /*
* __kmem_cache_create - Create a cache. * __kmem_cache_create - Create a cache.
* @cachep: cache management descriptor * @cachep: cache management descriptor
* @flags: SLAB flags * @flags: SLAB flags
* *
* Returns a ptr to the cache on success, NULL on failure. * Returns zero on success, nonzero on failure.
* Cannot be called within an int, but can be interrupted.
* The @ctor is run when new pages are allocated by the cache.
* *
* The flags are * The flags are
* *
@ -1907,8 +1905,6 @@ static bool set_on_slab_cache(struct kmem_cache *cachep,
* %SLAB_HWCACHE_ALIGN - Align the objects in this cache to a hardware * %SLAB_HWCACHE_ALIGN - Align the objects in this cache to a hardware
* cacheline. This can be beneficial if you're counting cycles as closely * cacheline. This can be beneficial if you're counting cycles as closely
* as davem. * as davem.
*
* Return: a pointer to the created cache or %NULL in case of error
*/ */
int __kmem_cache_create(struct kmem_cache *cachep, slab_flags_t flags) int __kmem_cache_create(struct kmem_cache *cachep, slab_flags_t flags)
{ {