iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

char: tpm: move to use request_irq by IRQF_NO_AUTOEN flag

Browse Source 
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.

Link: https://lore.kernel.org/patchwork/patch/1388765/
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
This commit is contained in:
Tian Tao 2021-05-17 09:18:44 +08:00 committed by Jarkko Sakkinen
parent 114e43371c
commit 446cd6f0f3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/char/tpm/tpm_tis_i2c_cr50.c
View File

@ -706,14 +706,14 @@ static int tpm_cr50_i2c_probe(struct i2c_client *client,
if (client->irq > 0) { if (client->irq > 0) {
rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler, rc = devm_request_irq(dev, client->irq, tpm_cr50_i2c_int_handler,
IRQF_TRIGGER_FALLING | IRQF_ONESHOT, IRQF_TRIGGER_FALLING | IRQF_ONESHOT |
IRQF_NO_AUTOEN,
dev->driver->name, chip); dev->driver->name, chip);
if (rc < 0) { if (rc < 0) {
dev_err(dev, "Failed to probe IRQ %d\n", client->irq); dev_err(dev, "Failed to probe IRQ %d\n", client->irq);
return rc; return rc;
} }
disable_irq(client->irq);
priv->irq = client->irq; priv->irq = client->irq;
} else { } else {
dev_warn(dev, "No IRQ, will use %ums delay for TPM ready\n", dev_warn(dev, "No IRQ, will use %ums delay for TPM ready\n",