iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

leds: pwm: check result of led_pwm_set() in led_pwm_add()

Browse Source 
led_pwm_set() now returns an error when setting the PWM fails.

Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
This commit is contained in:
Denis Osterland-Heim 2020-04-21 13:09:14 +00:00 committed by Pavel Machek
parent ba50e011b1
commit 44c606b005
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/leds/leds-pwm.c
View File

@ -91,15 +91,21 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv,
pwm_init_state(led_data->pwm, &led_data->pwmstate); pwm_init_state(led_data->pwm, &led_data->pwmstate);
ret = devm_led_classdev_register(dev, &led_data->cdev); ret = devm_led_classdev_register(dev, &led_data->cdev);
if (ret == 0) { if (ret) {
priv->num_leds++;
led_pwm_set(&led_data->cdev, led_data->cdev.brightness);
} else {
dev_err(dev, "failed to register PWM led for %s: %d\n", dev_err(dev, "failed to register PWM led for %s: %d\n",
led->name, ret); led->name, ret);
return ret;
} }
ret = led_pwm_set(&led_data->cdev, led_data->cdev.brightness);
if (ret) {
dev_err(dev, "failed to set led PWM value for %s: %d",
led->name, ret);
return ret; return ret;
}
priv->num_leds++;
return 0;
} }
static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv) static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)