iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

serial: 8250_pci: make setup_port() parameters explicitly unsigned

Browse Source 
[ Upstream commit 3a96e97ab4 ]

The bar and offset parameters to setup_port() are used in pointer math,
and while it would be very difficult to get them to wrap as a negative
number, just be "safe" and make them unsigned so that static checkers do
not trip over them unintentionally.

Cc: Jiri Slaby <jirislaby@kernel.org>
Reported-by: Jordy Zomer <jordy@pwning.systems>
Link: https://lore.kernel.org/r/20210726130717.2052096-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Greg Kroah-Hartman
2021-07-26 15:07:17 +02:00
parent 4beadefea8
commit 44fd61a8bd
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/tty/serial/8250/8250_pci.c
View File

@ -89,7 +89,7 @@ static void moan_device(const char *str, struct pci_dev *dev)
static int static int
setup_port(struct serial_private *priv, struct uart_8250_port *port, setup_port(struct serial_private *priv, struct uart_8250_port *port,
int bar, int offset, int regshift) u8 bar, unsigned int offset, int regshift)
{ {
struct pci_dev *dev = priv->dev; struct pci_dev *dev = priv->dev;