iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

regmap: Fix double unlock in the maple cache

Browse Source 
Doing the dance to drop the maple tree's internal spinlock means we need
multiple exit paths in our error handling.

Reported-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230403-regmap-maple-unlock-v1-1-89998991b16c@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Mark Brown 2023-04-03 21:02:39 +01:00
parent f033c26de5
commit 451941ac1e
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/base/regmap/regcache-maple.c
View File

@ -137,7 +137,7 @@ static int regcache_maple_drop(struct regmap *map, unsigned int min,
GFP_KERNEL);
if (!lower) {
ret = -ENOMEM;
goto out;
goto out_unlocked;
}
}
@ -151,7 +151,7 @@ static int regcache_maple_drop(struct regmap *map, unsigned int min,
GFP_KERNEL);
if (!upper) {
ret = -ENOMEM;
goto out;
goto out_unlocked;
}
}
@ -179,6 +179,7 @@ static int regcache_maple_drop(struct regmap *map, unsigned int min,
out:
mas_unlock(&mas);
out_unlocked:
kfree(lower);
kfree(upper);