iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ARM: SAMSUNG: Insert bitmap_gpio_int member in samsung_gpio_chip

Browse Source 
When a device uses GPIO interrupt, its driver assumes that GPIO
should be INPUT mode. However, GPIO of SAMSUNG SoC is sepated to
INPUT mode and INTERRUPT mode. They are set by 0x0 and 0xF in GPIO
control register. If the register is set to INPUT mode, the
interrupt never occur. Therefore, it's necessary to set INTERRUPT
mode instead of INPUT mode when the pin is used for GPIO interrupt.

This patch inserts the bitmap_gpio_int member in struct samsung_
gpio_chip in order to represent use of GPIO interrupt for each pin
and sets the related bit when s5p_register_gpio_interrupt function
is called.

Signed-off-by: Eunki Kim <eunki_kim@samsung.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
This commit is contained in:
Eunki Kim 2012-10-23 22:39:33 +09:00 committed by Kukjin Kim
parent 6f0c0580b7
commit 453e2dd768
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/arm/plat-samsung/include/plat/gpio-core.h
View File

@ -48,6 +48,7 @@ struct samsung_gpio_cfg;
* @config: special function and pull-resistor control information. * @config: special function and pull-resistor control information.
* @lock: Lock for exclusive access to this gpio bank. * @lock: Lock for exclusive access to this gpio bank.
* @pm_save: Save information for suspend/resume support. * @pm_save: Save information for suspend/resume support.
* @bitmap_gpio_int: Bitmap for representing GPIO interrupt or not.
* *
* This wrapper provides the necessary information for the Samsung * This wrapper provides the necessary information for the Samsung
* specific gpios being registered with gpiolib. * specific gpios being registered with gpiolib.
@ -71,6 +72,7 @@ struct samsung_gpio_chip {
#ifdef CONFIG_PM #ifdef CONFIG_PM
u32 pm_save[4]; u32 pm_save[4];
#endif #endif
u32 bitmap_gpio_int;
}; };
static inline struct samsung_gpio_chip *to_samsung_gpio(struct gpio_chip *gpc) static inline struct samsung_gpio_chip *to_samsung_gpio(struct gpio_chip *gpc)

8
arch/arm/plat-samsung/s5p-irq-gpioint.c
View File

@ -185,7 +185,7 @@ int __init s5p_register_gpio_interrupt(int pin)
/* check if the group has been already registered */ /* check if the group has been already registered */
if (my_chip->irq_base) if (my_chip->irq_base)
return my_chip->irq_base + offset; goto success;
/* register gpio group */ /* register gpio group */
ret = s5p_gpioint_add(my_chip); ret = s5p_gpioint_add(my_chip);
@ -193,9 +193,13 @@ int __init s5p_register_gpio_interrupt(int pin)
my_chip->chip.to_irq = samsung_gpiolib_to_irq; my_chip->chip.to_irq = samsung_gpiolib_to_irq;
printk(KERN_INFO "Registered interrupt support for gpio group %d.\n", printk(KERN_INFO "Registered interrupt support for gpio group %d.\n",
group); group);
return my_chip->irq_base + offset; goto success;
} }
return ret; return ret;
success:
my_chip->bitmap_gpio_int |= BIT(offset);
return my_chip->irq_base + offset;
} }
int __init s5p_register_gpioint_bank(int chain_irq, int start, int nr_groups) int __init s5p_register_gpioint_bank(int chain_irq, int start, int nr_groups)