iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

torture: Replace cpu_up/down() with add/remove_cpu()

Browse Source 
The core device API performs extra housekeeping bits that are missing
from directly calling cpu_up/down().

See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and
serialization during LPM") for an example description of what might go
wrong.

This also prepares to make cpu_up/down() a private interface of the CPU
subsystem.

Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: "Paul E. McKenney" <paulmck@kernel.org>
Link: https://lkml.kernel.org/r/20200323135110.30522-16-qais.yousef@arm.com
This commit is contained in:
Qais Yousef 2020-03-23 13:51:08 +00:00 committed by Thomas Gleixner
parent 20fb50295b
commit 457bc8ed3e
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
kernel/torture.c
View File

@ -97,7 +97,7 @@ bool torture_offline(int cpu, long *n_offl_attempts, long *n_offl_successes,
torture_type, cpu); torture_type, cpu);
starttime = jiffies; starttime = jiffies;
(*n_offl_attempts)++; (*n_offl_attempts)++;
ret = cpu_down(cpu); ret = remove_cpu(cpu);
if (ret) { if (ret) {
if (verbose) if (verbose)
pr_alert("%s" TORTURE_FLAG pr_alert("%s" TORTURE_FLAG
@ -148,7 +148,7 @@ bool torture_online(int cpu, long *n_onl_attempts, long *n_onl_successes,
torture_type, cpu); torture_type, cpu);
starttime = jiffies; starttime = jiffies;
(*n_onl_attempts)++; (*n_onl_attempts)++;
ret = cpu_up(cpu); ret = add_cpu(cpu);
if (ret) { if (ret) {
if (verbose) if (verbose)
pr_alert("%s" TORTURE_FLAG pr_alert("%s" TORTURE_FLAG
@ -192,17 +192,18 @@ torture_onoff(void *arg)
for_each_online_cpu(cpu) for_each_online_cpu(cpu)
maxcpu = cpu; maxcpu = cpu;
WARN_ON(maxcpu < 0); WARN_ON(maxcpu < 0);
if (!IS_MODULE(CONFIG_TORTURE_TEST)) if (!IS_MODULE(CONFIG_TORTURE_TEST)) {
for_each_possible_cpu(cpu) { for_each_possible_cpu(cpu) {
if (cpu_online(cpu)) if (cpu_online(cpu))
continue; continue;
ret = cpu_up(cpu); ret = add_cpu(cpu);
if (ret && verbose) { if (ret && verbose) {
pr_alert("%s" TORTURE_FLAG pr_alert("%s" TORTURE_FLAG
"%s: Initial online %d: errno %d\n", "%s: Initial online %d: errno %d\n",
__func__, torture_type, cpu, ret); __func__, torture_type, cpu, ret);
} }
} }
}
if (maxcpu == 0) { if (maxcpu == 0) {
VERBOSE_TOROUT_STRING("Only one CPU, so CPU-hotplug testing is disabled"); VERBOSE_TOROUT_STRING("Only one CPU, so CPU-hotplug testing is disabled");