net: caif: fix memory leak in ldisc_open
[ Upstream commit 58af3d3d54
]
Syzbot reported memory leak in tty_init_dev().
The problem was in unputted tty in ldisc_open()
static int ldisc_open(struct tty_struct *tty)
{
...
ser->tty = tty_kref_get(tty);
...
result = register_netdevice(dev);
if (result) {
rtnl_unlock();
free_netdev(dev);
return -ENODEV;
}
...
}
Ser pointer is netdev private_data, so after free_netdev()
this pointer goes away with unputted tty reference. So, fix
it by adding tty_kref_put() before freeing netdev.
Reported-and-tested-by: syzbot+f303e045423e617d2cad@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Sasha Levin
parent
7a442d4c7b
commit
45a99589a9
@ -362,6 +362,7 @@ static int ldisc_open(struct tty_struct *tty)
|
|||||||
rtnl_lock();
|
rtnl_lock();
|
||||||
result = register_netdevice(dev);
|
result = register_netdevice(dev);
|
||||||
if (result) {
|
if (result) {
|
||||||
|
tty_kref_put(tty);
|
||||||
rtnl_unlock();
|
rtnl_unlock();
|
||||||
free_netdev(dev);
|
free_netdev(dev);
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
|
Reference in New Issue
Block a user