iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iommu/mediatek: Fix forever loop in error handling

Browse Source 
There is a typo so this loop does i++ where i-- was intended.  It will
result in looping until the kernel crashes.

Fixes: 26593928564c ("iommu/mediatek: Add error path for loop of mm_dts_parse")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Yong Wu <yong.wu@mediatek.com>
Link: https://lore.kernel.org/r/Y5C3mTam2nkbaz6o@kili
Signed-off-by: Joerg Roedel <jroedel@suse.de>
This commit is contained in:
Dan Carpenter 2022-12-07 18:56:09 +03:00 committed by Joerg Roedel
parent 00ef8885a9
commit 462e768b55
1 changed files with 1 additions and 2 deletions

3
drivers/iommu/mtk_iommu.c

@ -1159,8 +1159,7 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m
return 0;
err_larbdev_put:
/* id may be not linear mapping, loop whole the array */
for (i = MTK_LARB_NR_MAX - 1; i >= 0; i++) {
for (i = MTK_LARB_NR_MAX - 1; i >= 0; i--) {
if (!data->larb_imu[i].dev)
continue;
put_device(data->larb_imu[i].dev);